-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation Updates #3938
Merged
Merged
Documentation Updates #3938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielduan
requested review from
Hypnosphi,
ndelangen and
shilman
as code owners
July 31, 2018 18:44
tmeasday
approved these changes
Jul 31, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great stuff @danielduan!
ndelangen
approved these changes
Aug 1, 2018
Hypnosphi
reviewed
Sep 1, 2018
- Without pronoun (good): `Users can also...` | ||
* Don't use `we` to refer to Storybook, contributors, or Storybook users. | ||
- Pronoun (bad): `We can create this component...` | ||
- Without pronoun (good): `The component can be created...` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this is passive voice
This was referenced Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Our docs have some grammatical and stylistic problems in English. I fixed some and added a README for other contributors' reference.
Some main points:
easy
orsimple
in our docs. Nothing is ever easy for users when they are confused.